Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault in SdkSpan.events #6244

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Conversation

johnbley
Copy link
Member

Most spans don't have events [citation needed]. So, fault it in like attributes and links rather than waste time/GC thrash allocating the storage for them.

@johnbley johnbley requested a review from a team February 22, 2024 15:52
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (77bb439) to head (572a3cb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6244      +/-   ##
============================================
- Coverage     91.01%   91.01%   -0.01%     
- Complexity     5685     5686       +1     
============================================
  Files           621      621              
  Lines         16642    16643       +1     
  Branches       1703     1704       +1     
============================================
  Hits          15147    15147              
  Misses         1005     1005              
- Partials        490      491       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable micro-optimization to me. Thanks!

@jkwatson jkwatson merged commit 96fe54f into open-telemetry:main Feb 24, 2024
18 checks passed
@johnbley johnbley deleted the fault_in_span_events branch February 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants