Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus exporter: remove non-ucum units from conversion #5719

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

dashpole
Copy link
Contributor

Description:

Discovered during open-telemetry/opentelemetry-go#4374 (review).

B means bel in UCUM, so MB is megabel, for example. $ is also not UCUM.

https://ucum.org/ucum#section-Alphabetic-Index-By-Symbol

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (c0f0ff8) 91.25% compared to head (0a9cc5b) 91.24%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5719      +/-   ##
============================================
- Coverage     91.25%   91.24%   -0.01%     
+ Complexity     5051     5045       -6     
============================================
  Files           558      558              
  Lines         14930    14924       -6     
  Branches       1397     1397              
============================================
- Hits          13624    13618       -6     
  Misses          899      899              
  Partials        407      407              
Files Changed Coverage Δ
...try/exporter/prometheus/PrometheusUnitsHelper.java 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole dashpole force-pushed the remove_non_ucum branch 2 times, most recently from 38888de to 89e1b5f Compare August 16, 2023 19:39
@dashpole
Copy link
Contributor Author

Failure seems unrelated:

> Task :sdk:metrics:compileTestJava
/home/runner/work/opentelemetry-java/opentelemetry-java/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/descriptor/MetricDescriptorTest.java:86: error: cannot find symbol
                Advice.create(Arrays.asList(1.0, 2.0))));
                      ^
  symbol:   method create(List<Double>)
  location: class Advice
1 error

> Task :sdk:metrics:compileTestJava FAILED

@jack-berg
Copy link
Member

Failure seems unrelated:

Yup, bad merge. Fixed in #5721. Pull in main after that is merged.

@dashpole dashpole marked this pull request as ready for review August 17, 2023 13:04
@dashpole dashpole requested a review from a team August 17, 2023 13:04
@jack-berg jack-berg merged commit 3669e7a into open-telemetry:main Aug 21, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants