Add a boolean field to set a Span as asynchronous. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
requested review from
bogdandrutu,
SergeyKanzhelev and
yurishkuro
as code owners
|
Can you add more details into issue why is it needed. I believe we wanted to defer adding this field for later |
|
hey hey @SergeyKanzhelev I'm adding children |
|
@carlosalberto I believe @yurishkuro has problem with calling it |
|
If the problem is the name (which I can understand), we can still keep this PR and update the name ;) |
|
@carlosalberto let's see how you can do with the name :) |
|
@yurishkuro Any suggestion on the name here? ;) |
|
I believe we decided to close this PR and come back to it later when we will agree on changes needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #14