Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP log export for the OpenTelemetry Spring Starter #8493

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

jeanbisutti
Copy link
Member

No description provided.

@jeanbisutti jeanbisutti requested a review from a team May 15, 2023 14:49
@jeanbisutti
Copy link
Member Author

cc @heyams

loggerProviderBuilder.addLogRecordProcessor(
SimpleLogRecordProcessor.create(loggerExporter)));
SdkLoggerProvider loggerProvider = loggerProviderBuilder.build();
GlobalLoggerProvider.set(loggerProvider);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future (next release, actually): we'll have to set GlobalOpenTelemetry if we want appenders to work. Not that there's anything wrong with that, it's just that it's a behavioral change that we'll have to introduce.

jeanbisutti and others added 5 commits June 5, 2023 14:28
…/io/opentelemetry/instrumentation/spring/autoconfigure/exporters/otlp/OtlpLoggerExporterAutoConfiguration.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
…/io/opentelemetry/instrumentation/spring/autoconfigure/exporters/otlp/OtlpLoggerExporterAutoConfiguration.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
…/io/opentelemetry/instrumentation/spring/autoconfigure/exporters/otlp/OtlpLoggerExporterAutoConfiguration.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
@trask trask merged commit 84a8187 into open-telemetry:main Jun 8, 2023
@trask
Copy link
Member

trask commented Jun 8, 2023

thx @jeanbisutti!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants