Add AwsAttributePropagatingSpanProcessor component to AWS X-Ray #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
force-pushed
the
remote_attributes
branch
3 times, most recently
from
01455a7
to
410b08b
Compare
willarmiros
approved these changes
Mar 13, 2023
jack-berg
reviewed
Mar 13, 2023
aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/RemoteAttributesSpanProcessor.java
Outdated
Show resolved
Hide resolved
bjrara
force-pushed
the
remote_attributes
branch
from
410b08b
to
c5365ec
Compare
jack-berg
approved these changes
Mar 15, 2023
aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/RemoteAttributesSpanProcessor.java
Outdated
Show resolved
Hide resolved
bjrara
force-pushed
the
remote_attributes
branch
from
c5365ec
to
3e91d01
Compare
willarmiros
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Additional changes LGTM! This can be merged whenever and thanks for the review @jack-berg
|
@open-telemetry/java-contrib-maintainers PTAL. |
|
Put this PR on hold as the component might need to extend its scope to cooperate with #789. |
bjrara
force-pushed
the
remote_attributes
branch
3 times, most recently
from
c55671a
to
666462e
Compare
bjrara
changed the title
bjrara
force-pushed
the
remote_attributes
branch
from
666462e
to
8ebe50e
Compare
This was referenced Apr 27, 2023
|
Because the author of this PR is not currently available, I have created a new PR here: #856 Please close this PR if you are able. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AwsAttributePropagatingSpanProcessoris designed to handle attributesaws.remote.application,aws.remote.operationandaws.local.operationwhich will later be used to generate metrics under the background of #789.It has a prerequisite PR #800.
Description
AwsAttributePropagatingSpanProcessoraccomplishes two things:1. Propagating remote attributes.
The
aws.remote.applicationandaws.remote.operationattributes are designed to be set by users into local client spans through manual instrumentation. However, since client spans are mostly generated by auto-instrumentation libraries which make them unaccessible to application developers.OTEP-207 seems to be a general solution that could help address this requirement, but it hasn't been finalized yet. We took the idea from this comment which suggests to let SpanProcessor to do the propagation work.
AwsAttributePropagatingSpanProcessoris used as an alternative solution that inheritaws.remote.applicationandaws.remote.operationattributes from parent span to the child spans if present.2. Setting and propagating local attributes.
SpanMetricsProcessorfrom #789 requiresaws.local.operation(the initial entry point of a execution) to be injected into the local client spans to generate metrics that can later be used for other correlations.AwsAttributePropagatingSpanProcessorsets this attribute with the span name of the local root span if the request is from remote, and passes it to child spans.Testing
JUnit test is created for this new component in the package.
Documentation
It's an independent component that would require manual installation in the TracerProvider. We'll create a doc to describe the usage.
Outstanding items
NONE.