-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glassfish service name detector #579
Glassfish service name detector #579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add to doc, with a brief explanation of where the service name is read from for each application server (Glassfish so far)?
Sure, I assume you want it in this module README or did you have something else in mind? |
👍 |
thx @breedx-splk! |
This builds on #579 (and will be rebased when that merges). It adds the remaining service name detectors for various app servers.
This is a continuation of #562 that introduces the first of several web app servers for which we will detect the service name.
Because this is the first (GlassFish), it includes some of the helper/plumbing utilities. Subsequent additions will mostly be the
AppServer
implementations (and adding them to the delegate list).