Add Jetty Integration #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2022 11:45
jmx-metrics/README.md
Outdated
| @@ -68,6 +68,7 @@ mutually exclusive with `otel.jmx.groovy.script`. The currently supported target | |||
|
|
|||
| | `otel.jmx.target.system` | | |||
| |--------------------------| | |||
| | [`jetty`](./docs/target-systems/jetty.md) | | |||
There was a problem hiding this comment.
It's not a great system, but we have jvm on top and external libs sorted below it.
| .withNetworkAliases("jetty") | ||
| .withExposedPorts(1099) | ||
| .withStartupTimeout(Duration.ofMinutes(2)) | ||
| .waitingFor(Wait.forListeningPort()); |
There was a problem hiding this comment.
Is there an informative log statement to wait for to help w/ potential flake?
...rationTest/java/io/opentelemetry/contrib/jmxmetrics/target_systems/JettyIntegrationTest.java
Outdated
Show resolved
Hide resolved
dehaansa
approved these changes
May 9, 2022
|
|
||
|
|
||
| * Name: `jetty.thread.queue.count` | ||
| * Description: The maximum amount of time a session has been active. |
There was a problem hiding this comment.
Looks like a copy-pasted description made it in.
|
@rmfitzpatrick Any chance you have some time to review this? |
rmfitzpatrick
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added Support for Jetty monitoring.
Testing:
Added Integration test for Jetty and updated supported tech tests.
Documentation:
Updated list of supported Tech.
Added Jetty doc.