Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates jmx-metrics WildFly integration with replacement MBean #232

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Updates jmx-metrics WildFly integration with replacement MBean #232

merged 1 commit into from
Feb 14, 2022

Conversation

StefanKurek
Copy link
Contributor

Description:

Updates jmx-metrics WildFly integration to point to integer attributes for some metrics. The session metrics previously pointed at attributes that were Strings and caused errors.

@StefanKurek
Copy link
Contributor Author

@rmfitzpatrick FYI this is a small fix which points to an MBean which has integer versions of attributes compared to the old MBean (the String attributes were causing issues).

@rmfitzpatrick
Copy link
Contributor

@StefanKurek have you considered a straightforward update to the integration test that would have detected this?

@StefanKurek
Copy link
Contributor Author

@StefanKurek have you considered a straightforward update to the integration test that would have detected this?

@rmfitzpatrick it's a good question. The initial implementation for this left out tests for these specific metrics because I believe it involved a more complicated setup of WildFly in order for them to come through (possibly installing an application jar/war which I don't think WildFly ships with any test examples). I can take a look and see if I can come up with something though.

@rmfitzpatrick
Copy link
Contributor

I can take a look and see if I can come up with something though.

Thanks, I think this would be a good addition for the target in the (near) future, but it doesn't seem necessary for this needed fix.

@rmfitzpatrick rmfitzpatrick merged commit 9656949 into open-telemetry:main Feb 14, 2022
@StefanKurek StefanKurek deleted the wildfly_metric_fix branch February 14, 2022 14:38
@StefanKurek
Copy link
Contributor Author

@rmfitzpatrick not sure how to contact you other than through this. would you be willing to sponsor my otel membership?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants