New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WildFly Monitoring #224

Merged

rmfitzpatrick merged 7 commits into open-telemetry:main from observIQ:wildfly

Feb 3, 2022

Contributor

jmwilliams89 commented Feb 2, 2022

Description:

Added WildFly monitoring capabilities.
Added support for overriding the underlying scraper in an integration test. This makes it possible to test WildFly, because it requires an additional client jar added to the classpath of the scraper.

Testing:

Added integration tests with a custom built scraper.

Documentation:

Added documentation for WildFly metrics.

jmwilliams89 added 5 commits

February 2, 2022 11:11


          Added wildfly monitoring capabilities

038ec08


          Updated wildfly metrics

96ee9b2


          Modified integration tests to support custom scraper builds

017eec3


          Updated documentation for test

6cc647f


          Fixed mbeans in wildfly script

d1daadf

jmwilliams89 requested a review from a team

February 2, 2022 16:20

github-actions bot assigned dehaansa, Mrod1598 and rmfitzpatrick

github-actions bot requested review from dehaansa, Mrod1598 and rmfitzpatrick

February 2, 2022 16:21

cyrille-leclerc added the component: jmx-metrics label

rmfitzpatrick reviewed

View reviewed changes

jmx-metrics/docs/target-systems/wildfly.md Show resolved Hide resolved

rmfitzpatrick reviewed

View reviewed changes

jmx-metrics/src/main/resources/target-systems/wildfly.groovy Show resolved Hide resolved

rmfitzpatrick reviewed

View reviewed changes

jmx-metrics/src/integrationTest/resources/wildfly/start.sh Show resolved Hide resolved

rmfitzpatrick reviewed

View reviewed changes

jmx-metrics/src/integrationTest/resources/target-systems/wildfly.properties Outdated Show resolved Hide resolved

rmfitzpatrick reviewed

View reviewed changes

...tionTest/java/io/opentelemetry/contrib/jmxmetrics/target_systems/WildflyIntegrationTest.java Outdated Show resolved Hide resolved

rmfitzpatrick reviewed

View reviewed changes

jmx-metrics/docs/target-systems/wildfly.md Outdated Show resolved Hide resolved

jmwilliams89 added 2 commits

February 2, 2022 14:53


          Updated description and removed unnecessary properties

a9b214c


          Updated wildfly docs to include jmx url

0a4e175

rmfitzpatrick approved these changes

View reviewed changes

Contributor

rmfitzpatrick left a comment

Thanks for the addition!

rmfitzpatrick merged commit 49729b3 into open-telemetry:main

jmwilliams89 deleted the wildfly branch

February 3, 2022 14:43

jmwilliams89 mentioned this pull request

REQUEST: New membership for jmwilliams89 open-telemetry/community#1036

Closed

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: jmx-metrics