Add Hbase Support #211
Merged
Add Hbase Support #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2022 19:05
added 2 commits
January 19, 2022 20:18
dehaansa
reviewed
Jan 20, 2022
|
@rmfitzpatrick This is ready for a review whenever you get a second. |
anuraaga
reviewed
Jan 21, 2022
added 2 commits
January 21, 2022 12:22
anuraaga
reviewed
Jan 24, 2022
| # HBASE_ROOT_LOGGER=INFO,DRFA | ||
| # The reason for changing default to RFA is to avoid the boundary case of filling out disk space as | ||
| # DRFA doesn't put any cap on the log size. Please refer to HBase-5655 for more context. | ||
| export HBASE_JMX_BASE="-Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false" |
There was a problem hiding this comment.
Ah didn't realize the Dockerfile was only for setting environment variables - does it work to use .withEnv in the testcontainers command instead of having a separate file? That'll keep things simple. If it's not possible though then this is fine too
There was a problem hiding this comment.
This overwrites an environment file that is already there so we can't just set the environment variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Support for Hbase.
Testing:
Add Integration test for hbase
Documentation:
Updated list of supported Tech.
Add hbase doc.