Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowing generated proto java sources #1146

Merged

Conversation

LikeTheSalad
Copy link
Contributor

There was an issue raised in the otel-android Slack channel where a user needed to add the OTel Android lib along with the opentelemetry-proto one in the same project. This caused a compilation issue due to duplicated proto classes across opentelemetry-proto and disk-buffering (added in OTel Android).

These changes aim to avoid this issue by renaming the generated proto classes' package for the disk-buffering project.

@LikeTheSalad LikeTheSalad requested a review from a team January 4, 2024 14:50
@trask
Copy link
Member

trask commented Jan 4, 2024

cc @zeitlinger

(automation isn't working due to open-telemetry/community#1826)

disk-buffering/build.gradle.kts Outdated Show resolved Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask trask merged commit b495ac8 into open-telemetry:main Jan 4, 2024
14 checks passed
@LikeTheSalad LikeTheSalad deleted the disk-buffering-proto-shadowing branch January 5, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants