Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent sampler prototypes using 56 bits of randomness #1063

Merged
merged 12 commits into from
Oct 18, 2023
Merged

consistent sampler prototypes using 56 bits of randomness #1063

merged 12 commits into from
Oct 18, 2023

Conversation

oertl
Copy link
Contributor

@oertl oertl commented Oct 3, 2023 •
edited
Loading

consistent sampler prototypes using 56 bits of randomness as proposed by

open-telemetry/oteps#235

still requires more unit tests

@oertl oertl marked this pull request as ready for review October 10, 2023 03:58
@oertl oertl requested a review from a team October 10, 2023 03:58
@trask trask added this to the v1.31.0 milestone Oct 10, 2023
trask
trask reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oertl would we deprecate the old consistent samplers in the future, or is there a long-term need for them? thx

consistent-sampling/build.gradle.kts Outdated Show resolved Hide resolved
@oertl
Copy link
Contributor Author

oertl commented Oct 16, 2023

@trask

@oertl would we deprecate the old consistent samplers in the future, or is there a long-term need for them? thx

I think there is no long-term need for them. The new samplers should replace the old ones as soon as the new specification is settled.

@trask
Copy link
Member

trask commented Oct 17, 2023

I think there is no long-term need for them. The new samplers should replace the old ones as soon as the new specification is settled.

just to confirm my understanding, the io.opentelemetry.contrib.sampler.consistent56 package is temporary, and the new classes will eventually end up under io.opentelemetry.contrib.sampler.consistent? thx

@oertl
Copy link
Contributor Author

oertl commented Oct 18, 2023

just to confirm my understanding, the io.opentelemetry.contrib.sampler.consistent56 package is temporary, and the new classes will eventually end up under io.opentelemetry.contrib.sampler.consistent? thx

yes, this is correct

@trask trask merged commit e466431 into open-telemetry:main Oct 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@PeterF778 PeterF778 PeterF778 approved these changes

Assignees

@oertl oertl

@PeterF778 PeterF778

Labels
None yet
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oertl @trask @PeterF778