Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to io.opentelemetry.semconv:opentelemetry-semconv #1055

Closed
wants to merge 1 commit into from

Conversation

deki
Copy link
Contributor

@deki deki commented Sep 27, 2023

Description:

io.opentelemetry:opentelemetry-semconv was moved to io.opentelemetry.semconv:opentelemetry-semconv and the former is now deprecated as per open-telemetry/opentelemetry-java#5786.

Existing Issue(s):

#1044

Testing:

Unittest execution

Documentation:

Outstanding items:

Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deki

Copy link
Member

@cyrille-leclerc cyrille-leclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.
I'm sorry but I propose a slightly different path forward:

I propose to decouple and solve later the question of adopting the new convention and to implement it aligning with the OTel Java Auto Instr that added a config flag OTEL_SEMCONV_STABILITY_OPT_IN / otel.semconv-stability.opt-in.
I created a PR narrowed down to the change of lib:

@@ -86,8 +86,8 @@ public void enrichSpan(SpanBuilder spanBuilder, ExecutionEvent executionEvent) {
spanBuilder.setAttribute(
MavenOtelSemanticAttributes.MAVEN_BUILD_CONTAINER_REGISTRY_URL,
"https://" + registryHostname);
spanBuilder.setAttribute(SemanticAttributes.HTTP_URL, "https://" + registryHostname);
spanBuilder.setAttribute(SemanticAttributes.HTTP_METHOD, "POST");
spanBuilder.setAttribute(SemanticAttributes.URL_FULL, "https://" + registryHostname);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to decouple and solve later the question of adopting the new convention and to implement it aligning with the OTel Java Auto Instr that added a config flag OTEL_SEMCONV_STABILITY_OPT_IN / otel.semconv-stability.opt-in.
I created a PR narrowed down to the change of lib:

@cyrille-leclerc
Copy link
Member

FYI
In addition to the PR to just change the Sem Conv lib:

I initiated a PR to add optional support for the stable HTTP Semantic Conventions on:

@laurit
Copy link
Contributor

laurit commented May 8, 2024

Closing in favor of #1299

@laurit laurit closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants