[WIP] Add WithMetricProvider for BatchSpanProcessor #5201
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
WithMetricProvider
option for theBatchSpanProcessor
, implementing the same metrics that are currently provided by opentelemetry-java.I roughly followed the comment in #2547, but so far only added support for the metrics currently supported in Java. I'm open to doing more, but felt a bit unsure especially of how to create a "new type that is the union of both Options" (which was suggested in the previous thread).
Testing
I haven't added any new tests yet. I suspect I probably want to add some sort of test in
batch_span_processor_test.go
to validate the metric behavior, but I'm not sure what exactly that should look like yet.Where I'd like guidance
panic
for now, but I'm almost certain that's not the preferred approach.