-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the sdk/metric/internal/exemplar
package
#4835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
January 19, 2024 19:00
cc @jsuereth |
This is a test helper function that is not exported outside of testing for the package. Use the exported name so the CI system doesn't complain about it not being used. It will be used in follow-up PRs.
dashpole
reviewed
Jan 23, 2024
dashpole
approved these changes
Jan 23, 2024
dmathieu
approved these changes
Jan 24, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4835 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 226 226
Lines 18481 18557 +76
=====================================
+ Hits 15222 15286 +64
- Misses 2973 2983 +10
- Partials 286 288 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #559
Add the implementation package of of OpenTelemetry metric exemplars reservoirs skeleton.
This PR is split from #4455 to reduce the size of changes being evaluated. It is meant to be followed up with changes included in that PR:
Lack of
ExemplarFilter
The
ExemplarFilter
interface currently defined in the specification is not included in this package. This is because open-telemetry/opentelemetry-specification#3820 removes this type and is expected to be merged.If open-telemetry/opentelemetry-specification#3820 fails to merge, or is modified to not remove the
ExemplarFilter
, it can be added back into this package (i.e. revert c4d8381).Offer dropped attributes
The
Offer
method of theExemplarReservoir
is defined to accept the full set of attributes a measurement is made with. However, there is an optional provision below this definition stating that it can also accept just the dropped attributes. This package defines the method to accept just the dropped attributes.The reason for this decision is based on the fact that
attribute.Set
'sFilter
method returns these values at no additional cost when the set is filtered. See this comment describing the performance improvement numbers.