-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporters/otlptracehttp] Do not log errors for 2XX response #3707
base: main
Are you sure you want to change the base?
Conversation
cc @dineshg13 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3707 +/- ##
=====================================
Coverage 79.7% 79.7%
=====================================
Files 171 171
Lines 12673 12673
=====================================
Hits 10103 10103
Misses 2357 2357
Partials 213 213
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoisting this as it was on a comment chain that got resolved:
On success, the server MUST respond with
HTTP 200 OK
.
If the request is only partially accepted (i.e. when the server accepts only parts of the data and rejects the rest), the server MUST respond with
HTTP 200 OK
.
Nothing other than a 200 OK response is according to spec.
The spec says cc @Aneurysm9 |
The OTel spec for OTLP/HTTP says that servers must respond to fully or partially successful requests with That other SDKs do something different doesn't mean that we need to follow their lead. |
@Aneurysm9 @songy23 I have created an issue on Spec . open-telemetry/opentelemetry-specification#3203 . It looks like we need a clarification on the spec for this issue. |
Fixes #3706