Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global logger uses an atomic value instead of a mutex. #3545

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #3545 (1cc6dea) into main (4014204) will increase coverage by 0.0%.
The diff coverage is 87.5%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3545   +/-   ##
=====================================
  Coverage   78.0%   78.0%           
=====================================
  Files        164     164           
  Lines      11799   11795    -4     
=====================================
- Hits        9212    9210    -2     
+ Misses      2391    2389    -2     
  Partials     196     196           
Impacted Files Coverage Δ
internal/global/internal_logging.go 83.3% <87.5%> (+8.3%) ⬆️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@jmacd
Copy link
Contributor

jmacd commented Dec 16, 2022

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@MrAlias MrAlias merged commit 0617172 into open-telemetry:main Dec 19, 2022
@MrAlias MrAlias added this to the Release v1.12.0 milestone Jan 27, 2023
@MrAlias MrAlias mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants