Update semantic conventions to v1.4.0, move to versioned package #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Aneurysm9
force-pushed
the
feat/semconv_schema_1.4.0
branch
from
781f27e
to
4300a06
Compare
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
MrAlias
approved these changes
Jun 9, 2021
XSAM
approved these changes
Jun 10, 2021
tigrannajaryan
approved these changes
Jun 10, 2021
|
This looks ready to merge, and I was hoping to do so but the sync with main seems to have included imports of the old package path. E.g. I can help fix the issues, but don't want to overstep. LMK if the help is wanted. |
Looks like that was the only instance. I'll get the fix pushed up once precommit is done running. |
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1975. Supersedes and closes #1890.