Skip to content

Commit

Permalink
null value test, changelog fix
Browse files Browse the repository at this point in the history
  • Loading branch information
m-posluszny committed Jan 22, 2024
1 parent 4766eec commit 141bcc9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Fixed

- Fixed missing Mix and Max values for `go.opentelemetry.io/otel/exporters/stdout/stdoutmetric` by introducing `MarshalText` and `MarshalJSON` for type `Extrema` in `go.opentelemetry.io/sdk/metric/metricdata`. (#4826)
- Fixed missing Mix and Max values for `go.opentelemetry.io/otel/exporters/stdout/stdoutmetric` by introducing `MarshalText` and `MarshalJSON` for type `Extrema` in `go.opentelemetry.io/sdk/metric/metricdata`. (#4827)

## [1.23.0-rc.1] 2024-01-18

Expand Down
2 changes: 2 additions & 0 deletions sdk/metric/metricdata/metricdatatest/assertion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1023,6 +1023,8 @@ func AssertMarshal[N int64 | float64](t *testing.T, expected string, i *metricda
}

func TestAssertMarshal(t *testing.T) {
AssertMarshal(t, "null", &metricdata.Extrema[int64]{})

AssertMarshal(t, "-1", &minFloat64A)
AssertMarshal(t, "3", &minFloat64B)
AssertMarshal(t, "-9.999999", &minFloat64D)
Expand Down

0 comments on commit 141bcc9

Please sign in to comment.