Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eBPF based instrumentation #15

Merged
merged 1 commit into from
Nov 16, 2022
Merged

eBPF based instrumentation #15

merged 1 commit into from
Nov 16, 2022

Conversation

edeNFed
Copy link
Contributor

@edeNFed edeNFed commented Nov 16, 2022

This is an exact copy of: #4
Signing the commits messed up the previous PR somehow.

@edeNFed edeNFed requested a review from a team November 16, 2022 07:26
@pellared
Copy link
Member

Signing the commits messed up the previous PR somehow.

What do you mean? Can you try fixing it instead of creating a new PR?

@edeNFed
Copy link
Contributor Author

edeNFed commented Nov 16, 2022

The commits in the previous PR were not signed, so merging was blocked.
I had to do git push --force on my fork to sign the commits, which closed the previous PR.
I tried fixing it before opening a new one but without luck 😞

I configured my git to auto-sign every commit, so this will not happen again.

@pellared
Copy link
Member

pellared commented Nov 16, 2022

git push --force on my fork to sign the commits, which closed the previous PR.

This is unusual. It is the common way to handle lack of signatures.

Aren't you able to do anything with the "go-instrumentation-maintainers" powers? I think that "maintainers" are usually repository admins.

so this will not happen again

It probably will. Maybe not for you, but for other contributors 😉

@pellared pellared closed this Nov 16, 2022
@pellared pellared reopened this Nov 16, 2022
@pellared
Copy link
Member

pellared commented Nov 16, 2022

This is strange.

I found that it can happen if one force-pushed after closing the PR (isaacs/github#361). This is the first time I see such an issue it may be good to keep 👀 on it.

PS. I avoid using main branch on forks.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #4 (comment):

I am approving as I think that this PR is too big to process it in a regular way. I suggest merging it as it is. People can always look at this PR and add comments. We may address comments as separate PRs

@edeNFed edeNFed merged commit e42d188 into open-telemetry:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants