Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single repo #98

Closed
wants to merge 4 commits into from
Closed

Conversation

tsloughter
Copy link
Member

This contains other commits, including support for open-telemetry/opentelemetry-specification#875

Such changes really show how badly we need to be in one repo so I'm opening this now.

The tests currently fail because of a bug in rebar3 where tests can't find the headers in the apps.

@tsloughter tsloughter requested a review from a team September 19, 2020 19:42
@ferd
Copy link
Member

ferd commented Sep 19, 2020

I'm checking out the path stuff.

@ferd
Copy link
Member

ferd commented Sep 19, 2020

I'm checking and ?current_meter is just not a macro that appears to be defined anywhere. It's not that the include files aren't included, it's that it's not defined in any of them. This and the ?new_instruments/1 and ?counter_add macros need to be prefixed with ?ot_ to work.

@tsloughter
Copy link
Member Author

Hah, yup, thanks. Forgot I renamed them so thought existing tests that worked before the restructure were just suddenly failing.

@hauleth
Copy link
Member

hauleth commented Sep 19, 2020

Why not use git subtree to maintain the edit history?

@tsloughter
Copy link
Member Author

I just tried it to see what the history would look like and it doesn't appear to keep any history. It creates a single commit (even when not using --squash).

@tsloughter
Copy link
Member Author

Or maybe you have to go through the history a different way? Some special log commands for viewing it?

@hauleth
Copy link
Member

hauleth commented Sep 21, 2020

I will test it in the evening here, and create additional PR if I succeed.

@hauleth hauleth mentioned this pull request Sep 21, 2020
@tsloughter
Copy link
Member Author

Using #99 instead.

@tsloughter tsloughter closed this Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants