Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to DiagnosticSource 5.0 preview4 #667

Merged
merged 3 commits into from
May 7, 2020
Merged

Update to DiagnosticSource 5.0 preview4 #667

merged 3 commits into from
May 7, 2020

Conversation

cijothomas
Copy link
Member

As requested in #660, I am updating the newest preview version of DiagnosticSource. This package is not yet available in nuget.org, so added a new nuget source (temporary, until nuget.org has this package).

This PR only updates DiagnosticSource version. Actual code leveraging the new Activity, ActivitySource (similar to the preview PR 660), is going to follow in separate PRs.

Fixes # .

Changes

(Please provide a brief description of the changes here.)

Checklist

  • I ran Unit Tests locally.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

The PR will automatically request reviews from code owners and trigger CI build and tests.

@cijothomas cijothomas changed the title Update to DiagnosticSource 5.0 preview5 Update to DiagnosticSource 5.0 preview4 May 7, 2020
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cijothomas

@SergeyKanzhelev
Copy link
Member

This change sets the repo in a very strong dependency on .NET release dates. And make it much harder for early adopters to try.

Can we keep this change in a separate PR for now? I want to keep the repo in a working state.

@bruno-garcia
Copy link
Member

@SergeyKanzhelev I believe this is a requirement for us to move from OTel.Api.Span to Activity

@reyang
Copy link
Member

reyang commented May 7, 2020

This change sets the repo in a very strong dependency on .NET release dates. And make it much harder for early adopters to try.

Can we keep this change in a separate PR for now? I want to keep the repo in a working state.

I think it is fine to have a dependency to .NET preview while OpenTelemetry .NET SDK is at alpha/beta stage?
For people who already use the current (alpha0.2) SDK, they can still use that.
We are making change to the next alpha release which will take breaking changes, and this requires a dependency on .NET preview.

<configuration>
<packageSources>
<clear />
<add key="NuGet" value="https://api.nuget.org/v3/index.json" />
<add key="Dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next week it will be on NuGet. Should be good to merge now than

@SergeyKanzhelev SergeyKanzhelev merged commit 92963a3 into open-telemetry:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants