-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to DiagnosticSource 5.0 preview4 #667
Update to DiagnosticSource 5.0 preview4 #667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cijothomas
This change sets the repo in a very strong dependency on .NET release dates. And make it much harder for early adopters to try. Can we keep this change in a separate PR for now? I want to keep the repo in a working state. |
@SergeyKanzhelev I believe this is a requirement for us to move from |
I think it is fine to have a dependency to .NET preview while OpenTelemetry .NET SDK is at alpha/beta stage? |
<configuration> | ||
<packageSources> | ||
<clear /> | ||
<add key="NuGet" value="https://api.nuget.org/v3/index.json" /> | ||
<add key="Dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next week it will be on NuGet. Should be good to merge now than
As requested in #660, I am updating the newest preview version of DiagnosticSource. This package is not yet available in nuget.org, so added a new nuget source (temporary, until nuget.org has this package).
This PR only updates DiagnosticSource version. Actual code leveraging the new Activity, ActivitySource (similar to the preview PR 660), is going to follow in separate PRs.
Fixes # .
Changes
(Please provide a brief description of the changes here.)
Checklist
For significant contributions please make sure you have completed the following items:
The PR will automatically request reviews from code owners and trigger CI build and tests.