Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Refactor AggregatorStore #5509

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Apr 4, 2024

Changes

  • Refactor AggregatorStore to reuse the code for taking MetricPoint snapshot

@utpilla utpilla requested a review from a team April 4, 2024 20:58
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (6250307) to head (a12caf8).
Report is 164 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5509      +/-   ##
==========================================
+ Coverage   83.38%   85.52%   +2.13%     
==========================================
  Files         297      289       -8     
  Lines       12531    12585      +54     
==========================================
+ Hits        10449    10763     +314     
+ Misses       2082     1822     -260     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.29% <100.00%> (?)
unittests-Solution-Stable 85.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 85.30% <100.00%> (+4.92%) ⬆️

... and 63 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title Refactor AggregatorStore [sdk-metrics] Refactor AggregatorStore Apr 4, 2024
@CodeBlanch CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Apr 4, 2024
@utpilla utpilla merged commit 3f4c73a into open-telemetry:main Apr 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants