-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASP.NET Core] Add test validating route information for non-mvc scenario #4105
Merged
cijothomas
merged 9 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/add-unit-test-for-route-in-minimal-apis
Feb 14, 2023
Merged
[ASP.NET Core] Add test validating route information for non-mvc scenario #4105
cijothomas
merged 9 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/add-unit-test-for-route-in-minimal-apis
Feb 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4105 +/- ##
==========================================
+ Coverage 85.51% 85.57% +0.05%
==========================================
Files 291 291
Lines 11380 11380
==========================================
+ Hits 9732 9738 +6
+ Misses 1648 1642 -6
|
cijothomas
reviewed
Jan 27, 2023
…tps://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-unit-test-for-route-in-minimal-apis
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
Issues and pull requests which have been flagged for closing due to inactivity
label
Feb 4, 2023
Kielek
approved these changes
Feb 6, 2023
test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
Stale
Issues and pull requests which have been flagged for closing due to inactivity
label
Feb 7, 2023
alanwest
approved these changes
Feb 7, 2023
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test towards #3461 #2986
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes