Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] Add test validating route information for non-mvc scenario #4105

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Jan 26, 2023

Unit test towards #3461 #2986

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar marked this pull request as ready for review January 26, 2023 17:54
@vishweshbankwar vishweshbankwar requested a review from a team January 26, 2023 17:54
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #4105 (56ffead) into main (fbbc57a) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4105      +/-   ##
==========================================
+ Coverage   85.51%   85.57%   +0.05%     
==========================================
  Files         291      291              
  Lines       11380    11380              
==========================================
+ Hits         9732     9738       +6     
+ Misses       1648     1642       -6     
Impacted Files Coverage Δ
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 82.81% <0.00%> (+2.34%) ⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 89.42% <0.00%> (+2.88%) ⬆️

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 4, 2023
@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 7, 2023
@cijothomas cijothomas merged commit d0829ff into open-telemetry:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants