Renaming BroadcastActivity #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Aug 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
+ Coverage 77.01% 77.03% +0.01%
==========================================
Files 220 220
Lines 6083 6083
==========================================
+ Hits 4685 4686 +1
+ Misses 1398 1397 -1
|
| @@ -41,7 +41,7 @@ public BroadcastActivityProcessor(IEnumerable<ActivityProcessor> processors) | |||
| throw new ArgumentException($"{nameof(processors)} collection is empty"); | |||
| } | |||
|
|
|||
| this.processors = processors; | |||
| this.processors = new List<ActivityProcessor>(processors); | |||
There was a problem hiding this comment.
Should we cast instead of creating a new. Earlier implementation of using IEnumerable was good. Is there a reason to change this to list?
There was a problem hiding this comment.
Issue #980 points to a perf issue
There was a problem hiding this comment.
My guess would be it was changed so that if the user changes it after the call, it won't impact us. But I like it because it will also save two allocations on every Activity (when doing the foreach in OnStart & OnEnd).
There was a problem hiding this comment.
@rajkumar-rangaraj refer to this #735 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #980, #979 .
Changes
Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes.For significant contributions please make sure you have completed the following items: