[sql] Workaround integration test failures #2086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:instrumentation.sqlclient
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
===========================================
+ Coverage 73.91% 90.90% +16.99%
===========================================
Files 267 7 -260
Lines 9615 286 -9329
===========================================
- Hits 7107 260 -6847
+ Misses 2508 26 -2482
Flags with carried forward coverage won't be shown. Click here to find out more. |
1 task
CodeBlanch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems latest/current Testcontainers.MsSql version isn't compatible with GitHub runners which were pushed out. This PR manually sets the image version temporarily so things will work. Also looks like the SqlEdge package has been completely deprecated. We're not currently running that in our CI but we might start if ARM gets introduced.
For details see: testcontainers/testcontainers-dotnet#1265