-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.StackExchangeRedis] Updates StackExchange.Redis
to 2.6.122
#1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
Infra work - CI/CD, code coverage, linters
comp:instrumentation.stackexchangeredis
Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
labels
Jul 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1961 +/- ##
==========================================
- Coverage 73.91% 72.62% -1.29%
==========================================
Files 267 305 +38
Lines 9615 11289 +1674
==========================================
+ Hits 7107 8199 +1092
- Misses 2508 3090 +582 Flags with carried forward coverage won't be shown. Click here to find out more. |
CodeBlanch
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rajkumar-rangaraj
approved these changes
Jul 17, 2024
Kielek
approved these changes
Jul 22, 2024
ezhang6811
pushed a commit
to ezhang6811/opentelemetry-dotnet-contrib
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:instrumentation.stackexchangeredis
Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
infra
Infra work - CI/CD, code coverage, linters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1951
Changes
Updates
StackExchange.Redis
to2.6.122
to resolve CVE warnings in a transitive dependency. See #1951 for additional details.Starting with version 2.6.80 of
StackExchange.Redis
the dependency causing the warning was dropped.Upgrading to
2.6.122
as this is the earliest version with the dependency fix and a correction to the type signature forIConnectionMultiplexer.RegisterProfiler
.Some tests have had the null-forgiving operator applied to variables. The test attributes look to cause those cases to be skipped if the variable wouldn't have been populated.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes