Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.GrpcCore] Update minimal supported version of Grpc.Core.Api to 2.46.6 #1940

Merged

Conversation

IliaBrahinets
Copy link
Member

@IliaBrahinets IliaBrahinets commented Jul 5, 2024

Related to #1936 (comment)

Changes

Update minimal supported version of Grpc.Core.Api to the latest (from 2.43.0 to 2.46.6).

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes
    * [] Unit tests added/updated
    * [] Changes in public API reviewed (if applicable)

@github-actions github-actions bot requested a review from pcwiese July 5, 2024 09:24
@github-actions github-actions bot added the comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore label Jul 5, 2024
@IliaBrahinets IliaBrahinets marked this pull request as ready for review July 5, 2024 09:25
@IliaBrahinets IliaBrahinets requested a review from a team July 5, 2024 09:25
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 13, 2024
@IliaBrahinets
Copy link
Member Author

@Kielek , I've made suggested changes, ready for another review.

@Kielek Kielek changed the title [Instrumentation.GrpcCore] Update version of Grpc.Core.Api [Instrumentation.GrpcCore] Update minimal supported version of Grpc.Core.Api to 2.46.6 Jul 22, 2024
@Kielek Kielek merged commit b4d9029 into open-telemetry:main Jul 22, 2024
60 checks passed
ezhang6811 pushed a commit to ezhang6811/opentelemetry-dotnet-contrib that referenced this pull request Aug 8, 2024
…ore.Api to 2.46.6 (open-telemetry#1940)

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants