-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.GrpcCore] Update minimal supported version of Grpc.Core.Api to 2.46.6 #1940
Merged
Kielek
merged 7 commits into
open-telemetry:main
from
IliaBrahinets:update-grpc-core-api-version
Jul 22, 2024
Merged
[Instrumentation.GrpcCore] Update minimal supported version of Grpc.Core.Api to 2.46.6 #1940
Kielek
merged 7 commits into
open-telemetry:main
from
IliaBrahinets:update-grpc-core-api-version
Jul 22, 2024
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:instrumentation.grpccore
Things related to OpenTelemetry.Instrumentation.GrpcCore
label
Jul 5, 2024
Kielek
reviewed
Jul 5, 2024
src/OpenTelemetry.Instrumentation.GrpcCore/OpenTelemetry.Instrumentation.GrpcCore.csproj
Outdated
Show resolved
Hide resolved
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
@Kielek , I've made suggested changes, ready for another review. |
Kielek
approved these changes
Jul 22, 2024
Kielek
changed the title
[Instrumentation.GrpcCore] Update version of Grpc.Core.Api
[Instrumentation.GrpcCore] Update minimal supported version of Grpc.Core.Api to 2.46.6
Jul 22, 2024
ezhang6811
pushed a commit
to ezhang6811/opentelemetry-dotnet-contrib
that referenced
this pull request
Aug 8, 2024
…ore.Api to 2.46.6 (open-telemetry#1940) Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1936 (comment)
Changes
Update minimal supported version of
Grpc.Core.Api
to the latest (from 2.43.0 to 2.46.6).Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes* [] Unit tests added/updated* [] Changes in public API reviewed (if applicable)