Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Simplify usage of SamplingResult constructor #1915

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 20, 2024

Changes

Cleanup code after 1.9.0 release. Ref: open-telemetry/opentelemetry-dotnet#5614
Minor other cleanups while checking all usages of the constructor.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek requested a review from a team June 20, 2024 08:01
@Kielek Kielek force-pushed the samplingresult-simplify-usage branch from b53ee7f to 2d671df Compare June 20, 2024 08:02
@github-actions github-actions bot requested a review from ejsmith June 20, 2024 08:03
@github-actions github-actions bot added comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient labels Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (71655ce) to head (2d671df).
Report is 335 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
+ Coverage   73.91%   79.97%   +6.05%     
==========================================
  Files         267       29     -238     
  Lines        9615      824    -8791     
==========================================
- Hits         7107      659    -6448     
+ Misses       2508      165    -2343     
Flag Coverage Δ
unittests-Instrumentation.AspNet 74.85% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 280 files with indirect coverage changes

@Kielek Kielek merged commit 9114d0b into open-telemetry:main Jun 20, 2024
62 checks passed
@Kielek Kielek deleted the samplingresult-simplify-usage branch June 20, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants