Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Host] Rename host detector namespace #1820

Merged
merged 5 commits into from
May 21, 2024

Conversation

matt-hensley
Copy link
Contributor

Changes

Changes are following guidelines in #1610.

  • Renames OpenTelemetry.ResourceDetectors.Host to OpenTelemetry.Resources.Host
  • Makes detector internal
  • Adds AddHostDetector extension method for ResourceBuilder

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@github-actions github-actions bot requested review from Kielek and lachmatt May 20, 2024 19:36
@matt-hensley matt-hensley marked this pull request as ready for review May 20, 2024 19:37
@matt-hensley matt-hensley requested a review from a team May 20, 2024 19:37
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.45%. Comparing base (71655ce) to head (9314b8a).
Report is 260 commits behind head on main.

Current head 9314b8a differs from pull request most recent head 9282e75

Please upload reports for the commit 9282e75 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
+ Coverage   73.91%   75.45%   +1.54%     
==========================================
  Files         267      300      +33     
  Lines        9615    11539    +1924     
==========================================
+ Hits         7107     8707    +1600     
- Misses       2508     2832     +324     
Flag Coverage Δ
unittests-Exporter.Geneva 61.52% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.39% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 78.78% <ø> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 52.87% <0.00%> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Resources.ProcessRuntime 72.91% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry.Resources.Host/HostDetector.cs 56.96% <ø> (ø)
...elemetry.Resources.Host/HostResourceEventSource.cs 16.66% <ø> (ø)
...ry.Resources.Host/HostResourceBuilderExtensions.cs 0.00% <0.00%> (ø)

... and 268 files with indirect coverage changes

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Kielek Kielek added the comp:resources.host Things related to OpenTelemetry.Resources.Host label May 21, 2024
Copy link
Contributor

@lachmatt lachmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit 7665900 into open-telemetry:main May 21, 2024
160 checks passed
@matt-hensley matt-hensley deleted the rename-host-detector branch July 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.host Things related to OpenTelemetry.Resources.Host
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants