-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sampler.AWS] AWS X-Ray remote sampler part 1 #1091
Conversation
4480901
to
ae73232
Compare
src/OpenTelemetry.Contrib.Extensions.AWSXRay/.publicApi/net462/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Contrib.Extensions.AWSXRay/Trace/AWSXRayRemoteSampler.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Contrib.Extensions.AWSXRay/Trace/AWSXRayRemoteSampler.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Contrib.Extensions.AWSXRay/Trace/AWSXRayRemoteSamplerBuilder.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Contrib.Extensions.AWSXRay/Trace/GetSamplingRulesResponse.cs
Outdated
Show resolved
Hide resolved
...metry.Contrib.Extensions.AWSXRay.Tests/OpenTelemetry.Contrib.Extensions.AWSXRay.Tests.csproj
Outdated
Show resolved
Hide resolved
...metry.Contrib.Extensions.AWSXRay.Tests/OpenTelemetry.Contrib.Extensions.AWSXRay.Tests.csproj
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Contrib.Extensions.AWSXRay.Tests/Trace/TestAWSXRaySamplerClient.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Contrib.Extensions.AWSXRay.Tests/Trace/TestAWSXRaySamplerClient.cs
Outdated
Show resolved
Hide resolved
bc7d083
to
7e119e2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
+ Coverage 71.12% 71.24% +0.12%
==========================================
Files 222 229 +7
Lines 8360 8493 +133
==========================================
+ Hits 5946 6051 +105
- Misses 2414 2442 +28
|
One last thing before approval for the scaffolding, please add projects to https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/595a9a34e3e0f10f25df64153a83889ad386a3fc/.github/component_owners.yml (in alphabetical order). |
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
@Kielek There's some failure in the |
@srprash rerun passed. Probably network related issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , as a scaffolding for further work
@Kielek So is it good to be merged? I will build upon this in future PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utpilla , could you please check?
test/OpenTelemetry.Sampler.AWS.Tests/OpenTelemetry.Sampler.AWS.Tests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some suggestions on fixing content of README and using $(RepoRoot)
.
Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com>
….Tests.csproj Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com>
New feature: AWS X-Ray remote sampler.
I am going to create a series of PRs for adding the X-Ray remote sampling support for OTel via the new
OpenTelemetry.Sampler.AWS
package.For more details on the X-Ray remote sampling, please refer to this doc: https://docs.aws.amazon.com/xray/latest/devguide/xray-concepts.html#xray-concepts-sampling
Changes
This PR is the first one in the series and introduces the following:
AWSXRayRemoteSampler
. The builder provides the configuration for the polling interval and the Otel collector xray proxy endpoint.AWSXRayRemoteSampler
overrides theShouldSample
method but currently throws anNotImplementedException
exception when an activity/span is started.AWSXRayRemoteSampler
upon initialization spins up a scheduled thread to fetch sampling rules from the X-Ray service. The sampling rules fetched are not stored anywhere in this current PR, but further implementation will build up on this logic.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes