Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade opentelemetry_ecto to 1.1.1 #899

Merged
merged 4 commits into from
May 31, 2023

Conversation

cedricziel
Copy link
Contributor

@cedricziel cedricziel commented May 23, 2023

Changes

Upgrade opentelemetry_ecto to 1.1.1

Fixes: #898

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@cedricziel cedricziel requested a review from a team May 23, 2023 11:42
@mviitane
Copy link
Member

We lack #903 from this branch. I cannot get the build working without it.

@cedricziel
Copy link
Contributor Author

@mviitane updated

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit c6c99fc into open-telemetry:main May 31, 2023
@cedricziel cedricziel deleted the erlang branch June 2, 2023 11:19
AlexanderWert pushed a commit to AlexanderWert/opentelemetry-demo that referenced this pull request Jul 24, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade octo_opentelemetry to 1.1.1 to fix metrics generation
5 participants