Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry Collector Data Flow Dashboard Preview #797

Conversation

devrimdemiroz
Copy link
Contributor

@devrimdemiroz devrimdemiroz commented Mar 18, 2023

Changes

A dashboard that shows Data Flow on Opentelemetry Collector over demo app.

DarkBluesCluttered

WhiteKnightCluttered

Merge Requirements

Waiting feedback and corrections ...

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the [docs][]

@devrimdemiroz devrimdemiroz requested a review from a team March 18, 2023 21:11
@austinlparker
Copy link
Member

Interesting - couple of notes from running it locally:

  • The span export ratio seems fine, but the metric export ratio seems strange?
  • Some more notes/annotations in the dashboard about what the actual metrics are measuring would be great.

This seems like a really good resource for people to learn about how to monitor pipelines.

@devrimdemiroz
Copy link
Contributor Author

devrimdemiroz commented Mar 19, 2023

Interesting - couple of notes from running it locally:

  • The span export ratio seems fine, but the metric export ratio seems strange?
  • Some more notes/annotations in the dashboard about what the actual metrics are measuring would be great.

This seems like a really good resource for people to learn about how to monitor pipelines.

The export ratio visibility idea belongs to @jpkrohling . And it is indeed great so that you can spot something is strange. The particular thing about opentelemetry demo app is that the spanmetrics configuration makes it strange. As it loops back within the collector configuration and does not exist among metrics incoming under otelcol_* namespace.

otelcol metrics spreadsheet I deep dived into what is coming. This list also has memory_delimiter, servicegraph processor and more in it. With the new connector system upcoming inside the collector, it might be better. However, it is good to know it is strange. 🤓

I have this as a base for documentation. I can convert it into a markdown format.

@cartersocha
Copy link
Contributor

The dashboard looks great!

Would it be possible to include the service source or slice some of these ingress metrics by attributes like that? Might be another dashboard haha

@devrimdemiroz
Copy link
Contributor Author

devrimdemiroz commented Mar 19, 2023

The dashboard looks great!

Would it be possible to include the service source or slice some of these ingress metrics by attributes like that? Might be another dashboard haha

Thanks!
I noted as remarks here, the labels are very limited. I agree. Enhancements on the collector side to be able to distinguish services and pipelines would be necessary.

@austinlparker
Copy link
Member

Yeah, if you can get the docs for this into markdown we'd love to pull it into the next release.

@cartersocha cartersocha added the docs-update-required Requires documentation update label Mar 20, 2023
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog.

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤩

Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@cartersocha cartersocha removed the docs-update-required Requires documentation update label Mar 21, 2023
@cartersocha cartersocha merged commit 74b1052 into open-telemetry:main Mar 21, 2023
@devrimdemiroz
Copy link
Contributor Author

Thank you for the great comments! 🥳 I hope it will help showcase the value of the OpenTelemetry Collector and make the demo application even more impressive.

@devrimdemiroz
Copy link
Contributor Author

Documentation PR --> open-telemetry/opentelemetry.io#2535

@puckpuck puckpuck added helm-update-required Requires an update to the Helm chart when released v1.4 required for 1.4 release labels Mar 23, 2023
@devrimdemiroz
Copy link
Contributor Author

Documentation merged on this one open-telemetry/opentelemetry.io#2569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released v1.4 required for 1.4 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants