Rebuild currency service Dockerfile with alpine #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
|
This made a HUGE difference on my machine. 43 vs. 407 seconds on my m2 mac book air. Thank you so much @svrnm @austinlparker we should release a new version immediately after we merge this and test the new build performance. Then maybe we can add another quick release for arm64 support unless other services continue to block us. I'd be curious if we could do something similar for the other slow services? fyi @GaryPWhite |
cartersocha
approved these changes
Jan 14, 2023
|
Wouldn't this also work for the rust image since its the same libs? Worth a shot. |
julianocosta89
requested changes
Jan 15, 2023
julianocosta89
approved these changes
Jan 15, 2023
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
|
Additional update: To reduce the final image size by ~300 MB (down to 65 on arm64) I turned it into a multi-stage build. |
fatsheep9146
approved these changes
Jan 16, 2023
|
Thanks @svrnm, this was an amazing improvement! |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should fix #681, #679 partially and #574: Alpine linux provides a grpc-dev package that can be used to skip all the dependencies for building opentelemetry-cpp
This brings down the build time to 2m 30s on an intel macbook pro (2015)
Merge Requirements
CHANGELOG.mdupdated to document new feature additions