Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit featureflagservice startup script if migrations fail #402

Conversation

joshleecreates
Copy link
Contributor

Fixes #398 .

Changes

Changes the startup shell script for the feature flag service to exit with a failure code if the migration command fails. This causes the pod to be automatically restarted in Kubernetes. In my tests, it always restarts once before successfully connecting to the database.

@joshleecreates joshleecreates requested a review from a team October 6, 2022 04:23
@joshleecreates joshleecreates force-pushed the issue-398-feature-flag-k8s-migrations branch from 60a7f7a to 6e6d3a6 Compare October 6, 2022 04:35
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the changes to IMAGE_VERSION. Looks good otherwise

.env Outdated Show resolved Hide resolved
@joshleecreates joshleecreates force-pushed the issue-398-feature-flag-k8s-migrations branch from 6e6d3a6 to 7018dc7 Compare October 6, 2022 18:47
@cartersocha cartersocha merged commit 7e68946 into open-telemetry:main Oct 6, 2022
@joshleecreates joshleecreates deleted the issue-398-feature-flag-k8s-migrations branch October 7, 2022 00:34
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

featureflagservice database migrations fail in kubernetes
3 participants