Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce initial run time #362

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Sep 13, 2022

References #252 and Fixes #349

Changes

This change makes it so people can go from git clone to seeing telemetry in under 2 minutes.

Makes use of docker image cache when running the application. This does not reduce build times. This change uses cache to reference existing images allowing users to run docker compose up --no-build and get a running demo application in about 90 seconds.

Building from main is still an initial 20 min ordeal for those that want to use the very latest.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@puckpuck puckpuck requested a review from a team September 13, 2022 03:03
@cartersocha
Copy link
Contributor

Nice - took around 5 mins for me

@cartersocha
Copy link
Contributor

Could you update the docker doc too?

@puckpuck
Copy link
Contributor Author

Could you update the docker doc too?

There is an update to that doc in this PR

@GaryPWhite
Copy link
Contributor

still interested to learn what happened with cache_to on builds elsewhere -- but this looks great :)

@mviitane
Copy link
Member

Looks good, makes it much faster to get started!

Probably not related (at least directly), but I can see the feature-flag-service crashing when starting with a clean environment, --no-build, and using M1 chip.

feature-flag-service     | qemu: uncaught target signal 11 (Segmentation fault) - core dumped
feature-flag-service     | Segmentation fault

Didn't have this problem previously when building the images.

docs/docker_deployment.md Outdated Show resolved Hide resolved
@puckpuck puckpuck merged commit 82f6cb0 into open-telemetry:main Sep 14, 2022
@puckpuck puckpuck deleted the build-from-cache branch September 14, 2022 04:08
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* specify -alpha version

* use pre-built images

* faster initial run time

* add verbiage about --no-build flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache export feature is currently not supported for docker driver
5 participants