Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete client programs #308

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Delete client programs #308

merged 6 commits into from
Aug 17, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Aug 16, 2022

Deletes clients to the services currencyservice and adservice.
The functionality of these programs is covered by /test/test.js

  • TODO: Add baggage functionality added from client.cpp to /test/test.js

I'm interested in if people have opinions on this removal or if this repository should provide any instructions or examples on how to write a gRPC client or is the focus more-so on the services.

@mic-max mic-max marked this pull request as ready for review August 16, 2022 18:44
@mic-max mic-max requested a review from a team August 16, 2022 18:44
@austinlparker
Copy link
Member

Uh, I'd expect other services to be using those clients... did the frontend use them before being refactored?

@mic-max
Copy link
Contributor Author

mic-max commented Aug 16, 2022

Uh, I'd expect other services to be using those clients... did the frontend use them before being refactored?

The other services create their own clients from the protocol buffer definition file.

@puckpuck
Copy link
Contributor

I'm all for removing the clients from this. They are meant to be used if you are locally developing just a specific service. This is a project to showcase OpenTelemetry data flowing through multiple services.

I think the clients will cause unnecessary confusion, and removing them helps avoid that confusion.

@mic-max mic-max marked this pull request as draft August 16, 2022 19:57
@mic-max
Copy link
Contributor Author

mic-max commented Aug 16, 2022

Converting to draft, have to remove clients from gradle and cmake

@reyang
Copy link
Member

reyang commented Aug 16, 2022

Adding @DebajitDas @lalitb who originally introduced the C++ client file and reviewed the PR #189.

I think the clients were used by the developers who have quick local test (whether it's functionality or perf or stress). Maybe these developers would find it helpful to keep the files somewhere (e.g. under a test folder)?

@lalitb
Copy link
Member

lalitb commented Aug 16, 2022

Yes. client code is handy for quick local tests, it would be good to have it in test directory, if it is causing any confusion.

@mic-max mic-max marked this pull request as ready for review August 16, 2022 22:19
@cartersocha cartersocha merged commit cc90ab8 into open-telemetry:main Aug 17, 2022
@mic-max mic-max deleted the cleinup branch August 18, 2022 06:02
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Delete client programs

* duplicate item to cart test

* gradle and cmake cleanup

* undo test change oops

Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants