Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add service version to OTEL_RESOURCE_ATTRIBUTES #1594

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Jun 4, 2024

Changes

As service.version is a recommended attribute, I'd like to propose adding it to the resource attributes env var.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team June 4, 2024 14:40
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Jun 4, 2024
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for this!

@julianocosta89 julianocosta89 merged commit d75c9d8 into open-telemetry:main Jun 5, 2024
28 checks passed
@julianocosta89 julianocosta89 deleted the add-service-version-to-resource-attributes branch June 5, 2024 09:35
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
…y#1594)

* chore: Add service version to OTEL_RESOURCE_ATTRIBUTES

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants