Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartservice: Add .NET process metrics #1265

Merged

Conversation

matt-hensley
Copy link
Contributor

@matt-hensley matt-hensley commented Nov 16, 2023

Changes

Installs .NET process metrics covering memory, CPU, and threads.

See details on reported metrics in OpenTelemetry.Instrumentation.Process README.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the [helm-charts][]

@matt-hensley matt-hensley marked this pull request as ready for review November 16, 2023 15:28
@matt-hensley matt-hensley requested a review from a team November 16, 2023 15:28
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 24, 2023
@mviitane
Copy link
Member

Builds and runs fine on mac/arm64. However, the GitHub linux/arm64 builder fails for some reason.

Screenshot 2023-11-27 at 10 39 27

@mviitane
Copy link
Member

We have in total 4 cartservice PRs open and they all fail in the GitHub linux/arm64 builder

@github-actions github-actions bot removed the Stale label Nov 28, 2023
@austinlparker austinlparker merged commit 18942fb into open-telemetry:main Nov 29, 2023
27 checks passed
@matt-hensley matt-hensley deleted the dotnet-process-metrics branch December 1, 2023 02:04
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add .NET process metrics

* CHANGELOG entry

---------

Co-authored-by: Austin Parker <austin@ap2.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants