Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling recommendationServiceCacheFailure is a noop #1626

Closed
flands opened this issue Jun 23, 2024 · 0 comments
Closed

Enabling recommendationServiceCacheFailure is a noop #1626

flands opened this issue Jun 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@flands
Copy link
Contributor

flands commented Jun 23, 2024

Bug Report

Which version of the demo you are using? 1.10.0

Symptom

Enabling recommendationServiceCacheFailure is a noop

What is the expected behavior?

Enabling recommendationServiceCacheFailure results in cache misses and latency

What is the actual behavior?

Enabling recommendationServiceCacheFailure is a noop

Reproduce

Edit src/flagd/demo.flagd.json and change the defaultVariant of recommendationServiceCacheFailure to on. Look for cache misses or latency in Jaeger

Additional Context

This appears to be a regression from at least version 1.7.0. As part of the featureflag to flagd change, it appears the recommendationCache featureflag name was changed to recommendationServiceCacheFailure but src/recommendationservice/recommendation_server.py was not updated accordingly. Either the recommendation service needs to be renamed or the flagd parameter needs to be changed back to what it was previously set to.

I'm happy to make this change depending on which way the community wants to go.

Also, likely good to audit whether other feature flags were impacted.

@flands flands added the bug Something isn't working label Jun 23, 2024
flands added a commit to flands/opentelemetry-demo that referenced this issue Jun 27, 2024
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this issue Jul 10, 2024
eliasmueller pushed a commit to UST-DeMAF/opentelemetry-demo that referenced this issue Jul 14, 2024
ahealy-newr pushed a commit to ahealy-newr/opentelemetry-demo-ahealy that referenced this issue Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants