adding instrumentation configuration #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettmc
commented
May 20, 2024
jack-berg
reviewed
May 20, 2024
tsloughter
reviewed
May 21, 2024
jack-berg
reviewed
May 22, 2024
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
brettmc
commented
May 23, 2024
|
Just FYI, I'm going to be offline on vacation for a couple of weeks and won't be able to work on this. |
Not sure if you'll see this, but I'd like to pick this up and run with it if you don't mind me pushing some commits to your branch. |
No problem at all! |
codeboten
reviewed
May 29, 2024
👍 let's add it to schema modeling rules |
…for property keys, remove db semconv options.
|
I pushed a commit to tweak a few things. Have a look folks! If we can get this merged, the next step is to start a conversation about figuring out how instrumentations can actually access this configuration via APIs. |
jack-berg
approved these changes
May 30, 2024
brettmc
commented
May 30, 2024
…telemetry-configuration into add-instrumentation
trask
approved these changes
May 30, 2024
|
@open-telemetry/configuration-maintainers PTAL when you can. Will merge thursday 6/6/24 if there are no additional comments. Thanks! |
jack-berg
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Aug 15, 2024
Resolves #3535. This introduces an API component to file configuration, which has been limited to SDK (i.e. end user facing) up until this point. The configuration model recently added the first surface area related to instrumentation configuration properties in open-telemetry/opentelemetry-configuration#91. The API proposed in this PR is collectively called the "Instrumentation config API", and provides a mechanism for instrumentation libraries to participate in file configuration and read relevant properties during initialization. The intent is for both OpenTelemetry-authored and native instrumentation alike to be able to be configured by users in a standard way. New API surface area is necessary to accomplish this to avoid instrumentation libraries from needing to take a dependency on SDK artifacts. The following summarizes the additions: - Introduce ConfigProvider, the instrumentation config API analog of TracerProvider, MeterProvider, LoggerProvider. This is the entry point to the API. - Define "Get instrumentation config" operation for ConfigProvider. This returns something called ConfigProperties, which is a programmatic representation of a YAML mapping node. The ConfigProperties returned by "Get instrumentation config" represents the [`.instrumentation`](https://github.com/open-telemetry/opentelemetry-configuration/blob/670901762dd5cce1eecee423b8660e69f71ef4be/examples/kitchen-sink.yaml#L438-L439) node defined in a config file. - Rebrand "file configuration" to "declarative configuration". This expresses the intent without coupling to the file representation, which although will be the most popular way to consume these features is just one possible way to represent the configuration model and use these tools. - Break out dedicated `api.md`, `data-model.md`, and `sdk.md` files for respective API, data model, and SDK portions of declarative configuration. This aligns with other portions of the spec. The separation should improve clarity regarding what should and should not be exposed in the API. I've prototyped this new API in `opentelemetry-java` here: open-telemetry/opentelemetry-java#6549 cc @open-telemetry/configuration-maintainers, @open-telemetry/specs-semconv-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft of adding instrumentation configuration.
commonproperty for settings that are common to multiple instrumentations (ie,otel.instrumentation.common.*), and added schema for the ones I know aboutCloses: #87