add log_level configuration #121
Conversation
This is to support the env variable OTEL_LOG_LEVEL. Fixes open-telemetry#120 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
Related: Until the spec defines an enum for log levels, opentelemetry-configuration can only represent a log level as a string, to be interpreted (differently) by each SDK implementation. |
examples/kitchen-sink.yaml
Outdated
| @@ -15,6 +15,11 @@ file_format: "0.1" | |||
| # Environment variable: OTEL_SDK_DISABLED | |||
| disabled: false | |||
|
|
|||
| # Configure the log level used by the SDK logger | |||
There was a problem hiding this comment.
What is the SDK logger? I think you mean to say the internal logger used internally by the SDK.
There was a problem hiding this comment.
There was a problem hiding this comment.
I know but I think that definition is lame. Can / should we do better?
| @@ -11,6 +11,9 @@ | |||
| "disabled": { | |||
| "type": ["boolean", "null"] | |||
| }, | |||
| "log_level": { | |||
| "type": ["string", "null"] | |||
There was a problem hiding this comment.
Can we have an enum based on a subset of the SeverityNumber enum defined in the proto repo? https://github.com/open-telemetry/opentelemetry-proto/blob/4f69356d853029975649c3f38b06fc77d77975fc/opentelemetry/proto/logs/v1/logs.proto#L86-L110
There was a problem hiding this comment.
We could, though without a resolution on open-telemetry/opentelemetry-specification#2039, we may be jumping ahead of the spec
This is to support the env variable OTEL_LOG_LEVEL.
Fixes #120