Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #116

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix build #116

merged 2 commits into from
Sep 3, 2024

Conversation

jack-berg
Copy link
Member

@tsloughter it looks like the build is broken after merging #94. Running make currently yields and doesn't run all the tasks:

cp -R /Users/jberg/code/open-telemetry/opentelemetry-configuration/validator/../schema /Users/jberg/code/open-telemetry/opentelemetry-configuration/validator/

Any idea what's up?

@jack-berg jack-berg requested a review from a team August 30, 2024 19:31
Makefile Show resolved Hide resolved
@tsloughter
Copy link
Member

Why didn't this cause the PR checks to fail?

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

@jack-berg
Copy link
Member Author

Why didn't this cause the PR checks to fail?

The build never calls make by itself - it always calls some more specific task.

@jack-berg jack-berg merged commit 05a15a8 into open-telemetry:main Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants