Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update attribute_keys to include type #111

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* Adding initial instrumentation configuration schema
* Split MetricExporter into PullMetricExporter and PushMetricExporter and ensure only PushMetricExporters can be associated with PeriodicMetricReader [#110](https://github.com/open-telemetry/opentelemetry-configuration/pull/110)
* Update `attribute_keys` from array to to Include type
codeboten marked this conversation as resolved.
Show resolved Hide resolved

## [v0.2.0] - 2024-05-08

Expand Down
6 changes: 4 additions & 2 deletions examples/kitchen-sink.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,10 @@ meter_provider:
record_min_max: true
# Configure attribute keys retained in the resulting stream(s).
attribute_keys:
- key1
- key2
# Configure list of attribute key patterns attribute keys retained in the resulting stream(s).
codeboten marked this conversation as resolved.
Show resolved Hide resolved
included:
codeboten marked this conversation as resolved.
Show resolved Hide resolved
- key1
- key2

# Configure text map context propagators.
#
Expand Down
12 changes: 12 additions & 0 deletions schema/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,18 @@
}
}
},
"Include": {
"type": "object",
"additionalProperties": false,
"properties": {
"included": {
"type": "array",
"items": {
"type": "string"
}
}
}
},
"Otlp": {
"type": ["object", "null"],
"additionalProperties": false,
Expand Down
5 changes: 1 addition & 4 deletions schema/meter_provider.json
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,7 @@
}
},
"attribute_keys": {
"type": "array",
"items": {
"type": ["string", "null"]
}
"$ref": "common.json#/$defs/Include"
}
}
}
Expand Down
Loading