Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs/rfc] RFC about environment variables #9854

Merged
merged 13 commits into from
Apr 30, 2024
Merged

[docs/rfc] RFC about environment variables #9854

merged 13 commits into from
Apr 30, 2024

Commits on Mar 27, 2024

  1. [docs/rfc] RFC about environment variables

    @mx-psi
    mx-psi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ac9a078 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Make some decisions

    @mx-psi
    mx-psi committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    026321d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mx-psi/env-vars

    @mx-psi
    mx-psi committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5ac7e49 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
    @mx-psi @codeboten
    mx-psi and codeboten committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2b0a23c View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
    @mx-psi @evan-bradley
    mx-psi and evan-bradley committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ed704e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Add a couple of links that were in review comments to the actual docu… 

    …ment
    @mx-psi
    mx-psi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1a0e9d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
    @mx-psi @codeboten
    mx-psi and codeboten committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    40333d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Address feedback from @TylerHelmuth 

    Make an invalid identifier an explicit error
    @mx-psi
    mx-psi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3f05467 View commit details
    Browse the repository at this point in the history

  2. Explicitly mention the comparison table within the body

    @mx-psi
    mx-psi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    0d45523 View commit details
    Browse the repository at this point in the history

  3. Clarify escaping rules

    @mx-psi
    mx-psi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    0862cc9 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'main' into mx-psi/env-vars

    @codeboten
    codeboten committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b7145d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Explicitly state why we support two syntaxes

    @mx-psi
    mx-psi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c8307a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
    @mx-psi @evan-bradley
    mx-psi and evan-bradley committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    90db1c0 View commit details
    Browse the repository at this point in the history