-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remotetap extension concept #10963
base: main
Are you sure you want to change the base?
Remotetap extension concept #10963
Conversation
Please create this PR in contrib? We will not have new components in this repository right now. |
Ah okay, then I will move the component back to contrib and will only update the processorhelper logic in core |
1872d48
to
ad62aab
Compare
@atoulme I moved the component from this PR to contrib: open-telemetry/opentelemetry-collector-contrib#34872. |
0b694d2
to
1033b02
Compare
@djaglowski I made the changes, let me know what you think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me. I suspect the most important thing to move this forward is to make sure it does not in any way interfere with the effort to mark modules 1.0, since this feature would necessarily be experimental for some time. If I am not mistaken, this means the changes to pdata
are likely problematic. Can we move them elsewhere, maybe to processorhelper
?
I could not move it to processorhelper because it causes some cyclic dep problems + ideally in the future I would like this interface by other types of components. I moved it to the component pkg, what do you think? IMO it fits great there, next to the telemetry.go that provides components the ability to report telemetry |
Unfortunately I think we have the same stability concern with |
Description
This is the core part of the remote tap concept described here: open-telemetry/opentelemetry-collector-contrib#34096
This will be used by the new version of the remotetap extension in contrib.
This new version uses the processorhelper to tap into the processor pipeline. ALL processors using the processorhelper to be created will automatically support this feature.
To see what a full version could look like you can check this POC: #10962
When no remotetap stream is open, the additional work on the processor pipeline is negligible (1 map read / proc consumption if the extension is not enabled, 2 map read / proc consumption if the extension is enabled but no streams are open)
Idealy, in the future, the feature would be available to all kinds of components. Taping into the processors that use the processorhelper pkg is the first easy step in this direction.