Change run_id log resource attribute to k8s.container.restart_count
#5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
run_id-restart_count
branch
from
b2be13a
to
55d256e
Compare
Change name of the attribute according to agreement in open-telemetry/opentelemetry-specification#1945. It's better if the actual change can be merged before the next release to avoid breaking changes in k8sattributes processor.
dmitryax
force-pushed
the
run_id-restart_count
branch
from
55d256e
to
6080277
Compare
mx-psi
approved these changes
Oct 4, 2021
tigrannajaryan
approved these changes
Oct 4, 2021
codeboten
reviewed
Oct 4, 2021
@tigrannajaryan I believe merging spec might take some time, but, if this PR goes after this week's release, it'll be another "breaking" change -- not so critical tho |
codeboten
approved these changes
Oct 4, 2021
I am only worried that the spec PR may be changed again forcing us to break Collector twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change name of the attribute according to agreement in open-telemetry/opentelemetry-specification#1945. It's better if the change can be merged before the next release to avoid breaking changes in k8sattributes processor after #5467