Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OTel-Arrow v0.26.0 #35057

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Use OTel-Arrow v0.26.0 #35057

merged 5 commits into from
Sep 6, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Sep 6, 2024

Description: There are no real changes here, except keeping up with collector dependencies. otel-arrow/v0.26.0 removes all the code that now resides in this repo's internal/otelarrow module.

@jmacd jmacd requested review from a team and dashpole September 6, 2024 17:12
@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 6, 2024
@mwear mwear added ready to merge Code review completed; ready to merge by maintainers and removed ready to merge Code review completed; ready to merge by maintainers labels Sep 6, 2024
songy23
songy23 reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make gotidy

@jmacd
Copy link
Contributor Author

jmacd commented Sep 6, 2024

Needs make gotidy

Yes, I noticed. Is there one make rule I could always run that would cover every possible pre-commit step? I'm aware of generate, gotidy, genotelarrowcol, crosslink, gci, fmt. It's really time consuming to get all of these details correct, especially when there are cross-module updates requiring a top-level make command (which is ... slow!).

@jmacd
Copy link
Contributor Author

jmacd commented Sep 6, 2024

^^^ this PR shows what a circus we're talking about. I ran make gotidy. I still have to run genotelcontribcol. This is a very difficult process.

@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Sep 6, 2024
@jmacd
Copy link
Contributor Author

jmacd commented Sep 6, 2024 •
edited
Loading

Reviewers and maintainers -- I appreciate the help getting this PR into a green state, but if this concerns you as well, please note that I have three other green PRs with approvals that I would appreciate being merged, that will be an even greater help. Thank you!

#35031
#34802
#34742

@songy23
Copy link
Member

songy23 commented Sep 6, 2024

Is there one make rule I could always run that would cover every possible pre-commit step?

I think make checks is the one you're looking for - it is pretty slow though, I myself don't make much use of it

@songy23 songy23 added dependencies Pull requests that update a dependency file ready to merge Code review completed; ready to merge by maintainers labels Sep 6, 2024
@jmacd
Copy link
Contributor Author

jmacd commented Sep 6, 2024

make checks

Thanks. It might save time, I'll try!

@codeboten codeboten merged commit 8c08765 into open-telemetry:main Sep 6, 2024
165 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
@jmacd @f7o
Use OTel-Arrow v0.26.0 (open-telemetry#35057)
3e58462 
**Description:** There are no real changes here, except keeping up with
collector dependencies. otel-arrow/v0.26.0 removes all the code that now
resides in this repo's `internal/otelarrow` module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@mwear mwear mwear approved these changes

@songy23 songy23 songy23 approved these changes

@moh-osman3 moh-osman3 moh-osman3 approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@lquerel lquerel Awaiting requested review from lquerel

Assignees

@bogdandrutu bogdandrutu

Labels
cmd/otelcontribcol otelcontribcol command dependencies Pull requests that update a dependency file exporter/otelarrow internal/otelarrow ready to merge Code review completed; ready to merge by maintainers receiver/otelarrow Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.109.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jmacd @songy23 @codeboten @mwear @moh-osman3 @bogdandrutu