[processor/deltatocumulative]: bugfix - process all samples #31349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an oversight, the processor stopped after the first sample. It should process all available samples per stream.
sh0rez
changed the title
26 tasks
ethercrow
reviewed
Feb 21, 2024
RichieSams
approved these changes
Feb 21, 2024
RichieSams
approved these changes
Feb 26, 2024
|
@djaglowski or @open-telemetry/collector-contrib-approvers Can someone additionally approve this PR? Github doesn't seem to count my approval, since I was made owner after this PR was created |
djaglowski
approved these changes
Feb 26, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…emetry#31349) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Due to an oversight, the processor stopped after the first sample. It should process all available samples per stream. **Testing:** Tests have been added to verify: - `Samples()` visits all samples - `Aggregate()` edits all samples **Issues** Fixes open-telemetry#31350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Due to an oversight, the processor stopped after the first sample. It should process all available samples per stream.
Testing:
Tests have been added to verify:
Samples()visits all samplesAggregate()edits all samplesIssues
Fixes #31350