awss3exporter: Add Protocol Buf storage format #30682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Jan 24, 2024
atoulme
reviewed
Jan 24, 2024
| m, err := newMarshaler("otlp_proto", zap.NewNop()) | ||
| assert.NoError(t, err) | ||
| require.NotNil(t, m) | ||
| assert.Equal(t, m.format(), "binpb") |
There was a problem hiding this comment.
Is binpb a good term here?
There was a problem hiding this comment.
I did have to look up what a binary protocol buffer file extension should be, according to the Protocol Buf site:
https://protobuf.dev/programming-guides/techniques/#suffixes
There was a problem hiding this comment.
Nice, thanks for the link! :)
Co-authored-by: Antoine Toulme <antoine@toulme.name>
|
Any @open-telemetry/collector-contrib-maintainer willing to give their blessing and merge this PR? |
I was indeed able to confirm that the existing Protobuf Marshaler does generate a byte stream that can be unmarshaled when read back from S3. |
TylerHelmuth
approved these changes
Jan 29, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
**Description:** Add ProtoBuf output format to the AWS S3 exporter **Link to tracking Issue:** open-telemetry#30681 **Testing:** Additional unit tests have been added for the new format type and I've also exported data to an S3 bucket in Protobuf format and read it back to confirm that it's working end to end. **Documentation:** Added details of the new marshaler format to the README.md --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add ProtoBuf output format to the AWS S3 exporter
Link to tracking Issue: #30681
Testing: Additional unit tests have been added for the new format type and I've also exported data to an S3 bucket in Protobuf format and read it back to confirm that it's working end to end.
Documentation: Added details of the new marshaler format to the README.md